Re: [PATCH] RDMA/rxe: Remove an unused member from struct rxe_mr

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



在 2022/8/26 17:34, Daisuke Matsuda 写道:
Commit 1e75550648da ("Revert "RDMA/rxe: Create duplicate mapping tables for
FMRs"") brought back the member 'va' to struct rxe_mr. However, it is
actually used by nobody and thus can be removed.


Missing Fixes?

Zhu Yanjun

Signed-off-by: Daisuke Matsuda <matsuda-daisuke@xxxxxxxxxxx>
---
  drivers/infiniband/sw/rxe/rxe_mr.c    | 1 -
  drivers/infiniband/sw/rxe/rxe_verbs.c | 1 -
  drivers/infiniband/sw/rxe/rxe_verbs.h | 1 -
  3 files changed, 3 deletions(-)

diff --git a/drivers/infiniband/sw/rxe/rxe_mr.c b/drivers/infiniband/sw/rxe/rxe_mr.c
index 850b80f5ad8b..814116ec4778 100644
--- a/drivers/infiniband/sw/rxe/rxe_mr.c
+++ b/drivers/infiniband/sw/rxe/rxe_mr.c
@@ -180,7 +180,6 @@ int rxe_mr_init_user(struct rxe_pd *pd, u64 start, u64 length, u64 iova,
  	mr->access = access;
  	mr->length = length;
  	mr->iova = iova;
-	mr->va = start;
  	mr->offset = ib_umem_offset(umem);
  	mr->state = RXE_MR_STATE_VALID;
  	mr->type = IB_MR_TYPE_USER;
diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.c b/drivers/infiniband/sw/rxe/rxe_verbs.c
index e264cf69bf55..9ebe9decad34 100644
--- a/drivers/infiniband/sw/rxe/rxe_verbs.c
+++ b/drivers/infiniband/sw/rxe/rxe_verbs.c
@@ -1007,7 +1007,6 @@ static int rxe_map_mr_sg(struct ib_mr *ibmr, struct scatterlist *sg,
n = ib_sg_to_pages(ibmr, sg, sg_nents, sg_offset, rxe_set_page); - mr->va = ibmr->iova;
  	mr->iova = ibmr->iova;
  	mr->length = ibmr->length;
  	mr->page_shift = ilog2(ibmr->page_size);
diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.h b/drivers/infiniband/sw/rxe/rxe_verbs.h
index 96af3e054f4d..a51819d0c345 100644
--- a/drivers/infiniband/sw/rxe/rxe_verbs.h
+++ b/drivers/infiniband/sw/rxe/rxe_verbs.h
@@ -305,7 +305,6 @@ struct rxe_mr {
  	u32			rkey;
  	enum rxe_mr_state	state;
  	enum ib_mr_type		type;
-	u64			va;
  	u64			iova;
  	size_t			length;
  	u32			offset;




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux