On 7/6/22 07:14, yangx.jy@xxxxxxxxxxx wrote: > On 2022/7/6 15:38, Pearson, Robert B wrote: >> Generally over time I have been adding a rxe_ prefix to all searchable names static or non static. >> This avoids collisions with similar names in other drivers with e.g. ctags. I agree a unified naming >> Scheme is good but would like to see one with a common prefix for subroutine names. > Hi Bob, > > I think it's hard to use unique name in all drivers. I saw that all > functions called by different qp states don't use the rxe_ prefix in > rxe_responders so just remove the rxe_ prefix. We can drop the patch if > you don't agree with this change. > > Best Regards, > Xiao Yang I fought on your side of this argument with Zhu a while back but now I am completely on his side. Linux has a lot of lines and generic subroutine names will very often collide all over the place. The better answer is to add rxe_ not remove it. It's not super critical so I have been doing it as a background task whenever I touch a piece of code. If you get the urge to make things more consistent feel free to do that but by adding a prefix and not deleting it. Bob
