On 7/12/22 5:54 AM, Leon Romanovsky wrote: > On Mon, Jul 11, 2022 at 10:54:38AM -0400, Dennis Dalessandro wrote: >> From: Ehab Ababneh <ehab.ababneh@xxxxxxxxxxxxxxxxxxxx> >> >> Both hfi1 and UML depend on x86_64, this can trigger build errors. >> This driver must depends on !UML because it accesses x86_64 >> features that are not supported by UML. >> >> Signed-off-by: Ehab Ababneh <ehab.ababneh@xxxxxxxxxxxxxxxxxxxx> >> Signed-off-by: Dennis Dalessandro <dennis.dalessandro@xxxxxxxxxxxxxxxxxxxx> >> --- >> drivers/infiniband/hw/hfi1/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-)a > > But why is this hfi1 specific change? > Shouldn't CONFIG_UML be disabled if someone choses !x86_64? This was discussed in [1]. Perhaps there is further work from UML folks warranted. However there really isn't any reason to try to compile a HW driver like hfi1 for UML and this will silence build warnings. 1: https://lore.kernel.org/linux-rdma/20220102070623.24009-1-rdunlap@xxxxxxxxxxxxx/ -Denny
