On Mon, Jul 11, 2022 at 10:54:38AM -0400, Dennis Dalessandro wrote: > From: Ehab Ababneh <ehab.ababneh@xxxxxxxxxxxxxxxxxxxx> > > Both hfi1 and UML depend on x86_64, this can trigger build errors. > This driver must depends on !UML because it accesses x86_64 > features that are not supported by UML. > > Signed-off-by: Ehab Ababneh <ehab.ababneh@xxxxxxxxxxxxxxxxxxxx> > Signed-off-by: Dennis Dalessandro <dennis.dalessandro@xxxxxxxxxxxxxxxxxxxx> > --- > drivers/infiniband/hw/hfi1/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)a But why is this hfi1 specific change? Shouldn't CONFIG_UML be disabled if someone choses !x86_64? Thanks > > diff --git a/drivers/infiniband/hw/hfi1/Kconfig b/drivers/infiniband/hw/hfi1/Kconfig > index 6eb739052121..14b92e12bf29 100644 > --- a/drivers/infiniband/hw/hfi1/Kconfig > +++ b/drivers/infiniband/hw/hfi1/Kconfig > @@ -1,7 +1,7 @@ > # SPDX-License-Identifier: GPL-2.0-only > config INFINIBAND_HFI1 > tristate "Cornelis OPX Gen1 support" > - depends on X86_64 && INFINIBAND_RDMAVT && I2C > + depends on X86_64 && INFINIBAND_RDMAVT && I2C && !UML > select MMU_NOTIFIER > select CRC32 > select I2C_ALGOBIT > >
