On 2022/3/1 0:04, Jason Gunthorpe wrote: > On Fri, Feb 25, 2022 at 07:25:57PM +0800, Wenpeng Liang wrote: >> @@ -282,7 +280,7 @@ struct ib_mr *hns_roce_rereg_user_mr(struct ib_mr *ibmr, int flags, u64 start, >> >> mailbox = hns_roce_alloc_cmd_mailbox(hr_dev); >> if (IS_ERR(mailbox)) >> - return ERR_CAST(mailbox); >> + return ERR_PTR(mailbox); > > This doesn't compile, it should stay as ERR_CAST, right? > > Jason > . > Yes, should keep using ERR_CAST, I missed the compile warning. Fix it in v3. Thanks, Wenpeng