Re: [PATCH v2 for-next 7/9] RDMA/hns: Clean up the return value check of hns_roce_alloc_cmd_mailbox()

[Jason Gunthorpe <jgg@xxxxxxxxxx>]

On Fri, Feb 25, 2022 at 07:25:57PM +0800, Wenpeng Liang wrote:
> @@ -282,7 +280,7 @@ struct ib_mr *hns_roce_rereg_user_mr(struct ib_mr *ibmr, int flags, u64 start,
>  
>  	mailbox = hns_roce_alloc_cmd_mailbox(hr_dev);
>  	if (IS_ERR(mailbox))
> -		return ERR_CAST(mailbox);
> +		return ERR_PTR(mailbox);

This doesn't compile, it should stay as ERR_CAST, right?

Jason