On Tue, Jan 4, 2022 at 8:00 AM Guoqing Jiang <guoqing.jiang@xxxxxxxxx> wrote:
>
>
>
> On 1/3/22 9:33 PM, Jack Wang wrote:
> > diff --git a/drivers/block/rnbd/rnbd-srv.h b/drivers/block/rnbd/rnbd-srv.h
> > index 98ddc31eb408..e5604bce123a 100644
> > --- a/drivers/block/rnbd/rnbd-srv.h
> > +++ b/drivers/block/rnbd/rnbd-srv.h
> > @@ -20,7 +20,7 @@
> > struct rnbd_srv_session {
> > /* Entry inside global sess_list */
> > struct list_head list;
> > - struct rtrs_srv *rtrs;
> > + struct rtrs_srv_sess *rtrs;
>
> How about change it to srv_sess?
I've kept the variable names as it is if it didn't include incorrect
naming. e.g. naming path variables with sess/session. Struct
names in the last 2 patches are changed just to make a clear
distinction. Doing variable name changes will probably require
a lot more changes in the files and I'm not sure if it's worth the
effort.
> > char sessname[NAME_MAX];
> > int queue_depth;
> > struct bio_set sess_bio_set;
> > diff --git a/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c b/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c
> > index 628ef20ebf0c..b94ae12c2795 100644
> > --- a/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c
> > +++ b/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c
> > @@ -154,7 +154,7 @@ static const struct attribute_group rtrs_srv_stats_attr_group = {
> >
> > static int rtrs_srv_create_once_sysfs_root_folders(struct rtrs_srv_path *srv_path)
> > {
> > - struct rtrs_srv *srv = srv_path->srv;
> > + struct rtrs_srv_sess *srv = srv_path->srv;
>
> It is srv here, maybe srv_sess too, FYI.
>
> [ ... ]
>
> > diff --git a/drivers/infiniband/ulp/rtrs/rtrs-srv.h b/drivers/infiniband/ulp/rtrs/rtrs-srv.h
> > index 6119e6708080..6292e87f6afd 100644
> > --- a/drivers/infiniband/ulp/rtrs/rtrs-srv.h
> > +++ b/drivers/infiniband/ulp/rtrs/rtrs-srv.h
> > @@ -73,7 +73,7 @@ struct rtrs_srv_mr {
> >
> > struct rtrs_srv_path {
> > struct rtrs_path s;
> > - struct rtrs_srv *srv;
> > + struct rtrs_srv_sess *srv;
>
> Ditto.
>
> Thanks,
> Guoqing
