Re: [PATCHv2 for-next 4/5] RDMA/rtrs-srv: Rename rtrs_srv to rtrs_srv_sess

[Guoqing Jiang <guoqing.jiang@xxxxxxxxx>]

On 1/3/22 9:33 PM, Jack Wang wrote:
> diff --git a/drivers/block/rnbd/rnbd-srv.h b/drivers/block/rnbd/rnbd-srv.h
> index 98ddc31eb408..e5604bce123a 100644
> --- a/drivers/block/rnbd/rnbd-srv.h
> +++ b/drivers/block/rnbd/rnbd-srv.h
> @@ -20,7 +20,7 @@
>   struct rnbd_srv_session {
>   	/* Entry inside global sess_list */
>   	struct list_head        list;
> -	struct rtrs_srv		*rtrs;
> +	struct rtrs_srv_sess	*rtrs;

How about change it to srv_sess?

>   	char			sessname[NAME_MAX];
>   	int			queue_depth;
>   	struct bio_set		sess_bio_set;
> diff --git a/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c b/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c
> index 628ef20ebf0c..b94ae12c2795 100644
> --- a/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c
> +++ b/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c
> @@ -154,7 +154,7 @@ static const struct attribute_group rtrs_srv_stats_attr_group = {
>   
>   static int rtrs_srv_create_once_sysfs_root_folders(struct rtrs_srv_path *srv_path)
>   {
> -	struct rtrs_srv *srv = srv_path->srv;
> +	struct rtrs_srv_sess *srv = srv_path->srv;

It is srv here, maybe srv_sess too, FYI.

[ ... ]

> diff --git a/drivers/infiniband/ulp/rtrs/rtrs-srv.h b/drivers/infiniband/ulp/rtrs/rtrs-srv.h
> index 6119e6708080..6292e87f6afd 100644
> --- a/drivers/infiniband/ulp/rtrs/rtrs-srv.h
> +++ b/drivers/infiniband/ulp/rtrs/rtrs-srv.h
> @@ -73,7 +73,7 @@ struct rtrs_srv_mr {
>   
>   struct rtrs_srv_path {
>   	struct rtrs_path	s;
> -	struct rtrs_srv	*srv;
> +	struct rtrs_srv_sess	*srv;

Ditto.

Thanks,
Guoqing