> From: Tony Nguyen <anthony.l.nguyen@xxxxxxxxx> > Sent: Tuesday, November 23, 2021 2:41 AM > > From: Shiraz Saleem <shiraz.saleem@xxxxxxxxx> > > Allow support for 'enable_iwarp' and 'enable_roce' devlink params to turn > on/off iWARP or RoCE protocol support for E800 devices. It is better to split this patch to two as there are two functionalities done here. 1. enable/disable roce as first patch 2. enable/disable iwarp as 2nd patch But I don't feel strong about it, as both has some inter dependency on checking other capabilities, so either way is fine. If you can split, it will be good.