On Mon, 25 Oct 2021 15:26:15 -0400 Sean Anderson wrote:
> >> How many did you fix?
> >
> > Strange, I thought coccinelle does pretty well on checkpatch compliance.
>
> It does, but the problem is there is no obvious place to break
>
> long_function_name(another_long_function_name(and_some_variable)))
>
> without introducing a variable.
Makes sense now.
> >> If it still applies cleanly, i would just apply it.
> >
> > It seems to apply but does not build (missing include in mlx4?)
>
> Hmm. I tried to determine if the correct headers were included, but it
> looks like there was an error there. In any case, it seems like David
> fixed it up when he applied it.
Ah, you're right! He noted:
Add missing linux/mii.h include to mellanox. -DaveM
I thought this was not applied since it was marked as "Not applicable"
in patchwork. Let me fix that to say "Accepted".
