On Sun, 24 Oct 2021 20:50:45 +0200 Andrew Lunn wrote: > On Fri, Oct 22, 2021 at 06:41:04PM -0400, Sean Anderson wrote: > > This converts instances of > > bitmap_foo(args..., __ETHTOOL_LINK_MODE_MASK_NBITS) > > to > > linkmode_foo(args...) > > It does touch a lot of files, but it does help keep the API uniform. > > > I manually fixed up some lines to prevent them from being excessively > > long. Otherwise, this change was generated with the following semantic > > patch: > > How many did you fix? Strange, I thought coccinelle does pretty well on checkpatch compliance. > > Because this touches so many files in the net tree, you may want to > > generate a new diff using the semantic patch above when you apply this. > > If it still applies cleanly, i would just apply it. It seems to apply but does not build (missing include in mlx4?) > Otherwise maybe Jakub could recreate it?