On Tue, Sep 28, 2021 at 5:41 PM Shoaib Rao <rao.shoaib@xxxxxxxxxx> wrote: > > > On 9/27/21 11:55 PM, Zhu Yanjun wrote: > > On Tue, Sep 28, 2021 at 12:38 PM Shoaib Rao <rao.shoaib@xxxxxxxxxx> wrote: > >> > >> On 9/27/21 6:46 PM, Zhu Yanjun wrote: > >>> On Tue, Sep 28, 2021 at 3:19 AM Jason Gunthorpe <jgg@xxxxxxxxxx> wrote: > >>>> On Tue, Sep 14, 2021 at 06:12:20PM -0700, Rao Shoaib wrote: > >>>>> In our internal testing we have found that > >>>>> default maximum values are too small. > >>>>> Ideally there should be no limits, but since > >>>>> maximum values are reported via ibv_query_device, > >>>>> we have to return some value. So, the default > >>>>> maximums have been changed to large values. > >>>>> > >>>>> Signed-off-by: Rao Shoaib <Rao.Shoaib@xxxxxxxxxx> > >>>>> --- > >>>>> > >>>>> Resubmitting the patch after applying Bob's latest patches and testing > >>>>> using via rping. > >>>>> > >>>>> drivers/infiniband/sw/rxe/rxe_param.h | 30 ++++++++++++++------------- > >>>>> 1 file changed, 16 insertions(+), 14 deletions(-) > >>>> So are we good with this? Bob? Zhu? > >>> I have already checked this commit. And I have found 2 problems with > >>> this commit. > >>> This commit changes many MAXs. > >>> And now rxe is not stable enough. Not sure this commit will cause the > >>> new problems. > >>> > >>> Zhu Yanjun > >> Hi Zhu, > >> > >> A generic statement without any technical data does not help. As far as > >> I am aware, currently there are no outstanding issues. If there are, > >> please provide data that clearly shows that the issue is caused by this > >> patch. > > Hi, Shoaib > > > > With this commit, I found 2 problems. > > This is why I suspect that this commit will introduce risks. > > Hi Zhu, > > I did full testing before I sent the patch, that is how I found that > rping did not work. What are the issues that you found? How to I > reproduce those issues? Sorry. What tests do you make? Do you make tests with the followings: 1. your commit + latest kernel <------rping------- > 5.10 stable kernel 2. your commit + latest kernel < ------rping------- > 5.11 stable kernel 3. your commit + latest kernel < ------rping------- > 5.12 stable kernel 4. your commit + latest kernel < ------rping------- > 5.13 stable kernel 5. your commit + latest kernel < ------rping------- > 5.14 stable kernel 6. rdma-core tests with your commit + latest kernel Zhu Yanjun > > Shoaib > > > > > Before a commit is sent to the upstream, please make full tests with it. > > > > Zhu Yanjun > > > >> Thanks you. > >> > >> Shoaib > >> > >>>>> - RXE_MAX_MR_INDEX = 0x00010000, > >>>>> + RXE_MAX_MR_INDEX = DEFAULT_MAX_VALUE, > >>>>> + RXE_MAX_MR = DEFAULT_MAX_VALUE - RXE_MIN_MR_INDEX, > >>>> Bob, were you saying this was what needed to be bigger to pass > >>>> blktests?? > >>>> > >>>> Jason
