On Tue, Sep 28, 2021 at 3:19 AM Jason Gunthorpe <jgg@xxxxxxxxxx> wrote: > > On Tue, Sep 14, 2021 at 06:12:20PM -0700, Rao Shoaib wrote: > > In our internal testing we have found that > > default maximum values are too small. > > Ideally there should be no limits, but since > > maximum values are reported via ibv_query_device, > > we have to return some value. So, the default > > maximums have been changed to large values. > > > > Signed-off-by: Rao Shoaib <Rao.Shoaib@xxxxxxxxxx> > > --- > > > > Resubmitting the patch after applying Bob's latest patches and testing > > using via rping. > > > > drivers/infiniband/sw/rxe/rxe_param.h | 30 ++++++++++++++------------- > > 1 file changed, 16 insertions(+), 14 deletions(-) > > So are we good with this? Bob? Zhu? I have already checked this commit. And I have found 2 problems with this commit. This commit changes many MAXs. And now rxe is not stable enough. Not sure this commit will cause the new problems. Zhu Yanjun > > > - RXE_MAX_MR_INDEX = 0x00010000, > > + RXE_MAX_MR_INDEX = DEFAULT_MAX_VALUE, > > + RXE_MAX_MR = DEFAULT_MAX_VALUE - RXE_MIN_MR_INDEX, > > Bob, were you saying this was what needed to be bigger to pass > blktests?? > > Jason