On Thu, Jul 22, 2021 at 05:01:30PM +0300, Leon Romanovsky wrote: > On Thu, Jul 22, 2021 at 10:02:31AM -0300, Jason Gunthorpe wrote: > > On Thu, Jul 22, 2021 at 03:57:39PM +0300, Leon Romanovsky wrote: > > > > > We are talking about two different issues that this refcount_read patch pointed. > > > You are focused on wrong usage of completion, I saw useless compare of > > > refcount_t with 0 that can't be. > > > > It can be zero. Anything that does refcount_dec_and_test() can make > > the refcount be zero. > > It can be, but it is not the case at least for iwpm. That is even more broken then. Structs with non-zero refcounts in them should not be freed. Jason
