Previous atomic increment decrement logic expects the atomic count to be '0' after the final decrement. Replacing atomic count with refcount does not allow that as refcount_dec() considers count of 1 as underflow. Therefore fix the current refcount logic by decrementing the refcount if one on the final deref in c4iw_destroy_cq(). Fixes: 7183451f846d (RDMA/cxgb4: Use refcount_t instead of atomic_t for reference counting") Signed-off-by: Dakshaja Uppalapati <dakshaja@xxxxxxxxxxx> Reviewed-by: Potnuri Bharat Teja <bharat@xxxxxxxxxxx> --- drivers/infiniband/hw/cxgb4/cq.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/cxgb4/cq.c b/drivers/infiniband/hw/cxgb4/cq.c index 6c8c910..54a5b60 100644 --- a/drivers/infiniband/hw/cxgb4/cq.c +++ b/drivers/infiniband/hw/cxgb4/cq.c @@ -976,8 +976,7 @@ int c4iw_destroy_cq(struct ib_cq *ib_cq, struct ib_udata *udata) chp = to_c4iw_cq(ib_cq); xa_erase_irq(&chp->rhp->cqs, chp->cq.cqid); - refcount_dec(&chp->refcnt); - wait_event(chp->wait, !refcount_read(&chp->refcnt)); + wait_event(chp->wait, refcount_dec_if_one(&chp->refcnt)); ucontext = rdma_udata_to_drv_context(udata, struct c4iw_ucontext, ibucontext); -- 1.8.3.1
