On Thursday, July 07/22/21, 2021 at 10:02:31 -0300, Jason Gunthorpe wrote: > On Thu, Jul 22, 2021 at 03:57:39PM +0300, Leon Romanovsky wrote: > > > We are talking about two different issues that this refcount_read patch pointed. > > You are focused on wrong usage of completion, I saw useless compare of > > refcount_t with 0 that can't be. > > It can be zero. Anything that does refcount_dec_and_test() can make > the refcount be zero. > > The issue here is that refcount_dec() cannot make the refcount zero as > it is improper use of the API. Hi Jason I didn't understood properly. Can you please tell that the current patch for cxgb4 is still wrong? Thanks Dakshaja
