> On 21 Jun 2021, at 16:37, Jason Gunthorpe <jgg@xxxxxxxxxx> wrote:
>
> On Mon, Jun 21, 2021 at 10:46:26AM +0000, Haakon Bugge wrote:
>
>>>> You're running an old checkpatch. Since commit bdc48fa11e46 ("checkpatch/coding-style: deprecate 80-column warning"), the default line-length is 100. As Linus states in:
>>>>
>>>> https://lkml.org/lkml/2009/12/17/229
>>>>
>>>> "... But 80 characters is causing too many idiotic changes."
>>>
>>> I'm aware of that thread, but RDMA subsystem continues to use 80 symbols limit.
>>
>> I wasn't aware. Where is that documented? Further, it must be a
>> limit that is not enforced. Of the last 100 commits in
>> drivers/infiniband, there are 630 lines longer than 80.
>
> Linus said stick to 80 but use your best judgement if going past
>
> It was not a blanket allowance to needless long lines all over the
> place.
That is not how I interpreted him:
<quote>
I don't think any kernel developers use a vt100 any more. And even if they
do, I bet they curse the "24 lines" more than they curse the occasional
80+ character lines.
I'd be ok with changing the warning to 132 characters, which is another
perfectly fine historical limit. Or we can split the difference, and say
"ok, 106 characters is too much". I don't care. But 80 characters is
causing too many idiotic changes.
</quote>
I think his last sentence pretty much covers the line splitting I did in the v3.
And now we have to explicit add --max-line-length=80 running checkpatch, since it defaults to 100 chars.
Personally, I do not see the value of occasionally require 80 chars line-lengths.
Thxs, Håkon
