> Subject: irdma: utils.c typos in irdma_cqp_gather_stats_gen1 ? > > There are some odd mismatches in field and access index. > These may be simple cut/paste typos. > > Are these intentional? No. Accidental. Likely cut/copy mistake. I will send a fix. Thanks Joe! Shiraz > > ip4txfrag is set to the value from IP4RXFRAGS > > 915cc7ac0f8e2a (Mustafa Ismail 2021-06-02 15:51:34 -0500 1753) gather_stats- > >ip4txfrag = > 915cc7ac0f8e2a (Mustafa Ismail 2021-06-02 15:51:34 -0500 1754) rd64(dev- > >hw, > 915cc7ac0f8e2a (Mustafa Ismail 2021-06-02 15:51:34 -0500 1755) dev- > >hw_stats_regs_64[IRDMA_HW_STAT_INDEX_IP4RXFRAGS] > 915cc7ac0f8e2a (Mustafa Ismail 2021-06-02 15:51:34 -0500 1756) + > stats_inst_offset_64); > > ip4txfrag is set again a few lines later, so the case above is probably a defect. > > 915cc7ac0f8e2a (Mustafa Ismail 2021-06-02 15:51:34 -0500 1769) gather_stats- > >ip4txfrag = > 915cc7ac0f8e2a (Mustafa Ismail 2021-06-02 15:51:34 -0500 1770) rd64(dev- > >hw, > 915cc7ac0f8e2a (Mustafa Ismail 2021-06-02 15:51:34 -0500 1771) dev- > >hw_stats_regs_64[IRDMA_HW_STAT_INDEX_IP4TXFRAGS] > 915cc7ac0f8e2a (Mustafa Ismail 2021-06-02 15:51:34 -0500 1772) + > stats_inst_offset_64); > > And here ip6txfrag is set to the value of IP6RXFRAGS > > 915cc7ac0f8e2a (Mustafa Ismail 2021-06-02 15:51:34 -0500 1785) gather_stats- > >ip6txfrags = > 915cc7ac0f8e2a (Mustafa Ismail 2021-06-02 15:51:34 -0500 1786) rd64(dev- > >hw, > 915cc7ac0f8e2a (Mustafa Ismail 2021-06-02 15:51:34 -0500 1787) dev- > >hw_stats_regs_64[IRDMA_HW_STAT_INDEX_IP6RXFRAGS] > 915cc7ac0f8e2a (Mustafa Ismail 2021-06-02 15:51:34 -0500 1788) + > stats_inst_offset_64); >
