On 4/20/21 1:38 AM, Zhu Yanjun wrote:
> On Thu, Apr 15, 2021 at 10:55 AM Bob Pearson <rpearsonhpe@xxxxxxxxx> wrote:
>>
>> Implement invalidate MW and cleaned up invalidate MR operations.
>>
>> Added code to perform remote invalidate for send with invalidate.
>> Added code to perform local invalidation.
>> Deleted some blank lines in rxe_loc.h.
>>
>> Signed-off-by: Bob Pearson <rpearson@xxxxxxx>
>> ---
>> drivers/infiniband/sw/rxe/rxe_loc.h | 23 ++++-----
>> drivers/infiniband/sw/rxe/rxe_mr.c | 59 +++++++++++++++++------
>> drivers/infiniband/sw/rxe/rxe_mw.c | 67 +++++++++++++++++++++++++++
>> drivers/infiniband/sw/rxe/rxe_req.c | 22 +++++----
>> drivers/infiniband/sw/rxe/rxe_resp.c | 52 +++++++++++++--------
>> drivers/infiniband/sw/rxe/rxe_verbs.h | 23 +++++----
>> 6 files changed, 178 insertions(+), 68 deletions(-)
>>
>> diff --git a/drivers/infiniband/sw/rxe/rxe_loc.h b/drivers/infiniband/sw/rxe/rxe_loc.h
>> index e6f574973298..7f1117c51e30 100644
>> --- a/drivers/infiniband/sw/rxe/rxe_loc.h
>> +++ b/drivers/infiniband/sw/rxe/rxe_loc.h
>> @@ -76,41 +76,34 @@ enum copy_direction {
>> from_mr_obj,
>> };
>>
>> +enum lookup_type {
>> + lookup_local,
>> + lookup_remote,
>> +};
>> +
>
> https://www.kernel.org/doc/Documentation/process/coding-style.rst
> "
>
> 12) Macros, Enums and RTL
> -------------------------
>
> Names of macros defining constants and labels in enums are capitalized.
>
> "
> Zhu Yanjun
>
Agreed. It's original code. I just moved it ahead of the prototypes. I've been wanting to fix this
so this is the perfect excuse.
Bob
