On 4/20/21 7:04 AM, Jason Gunthorpe wrote:
> On Tue, Apr 20, 2021 at 02:34:07PM +0800, Zhu Yanjun wrote:
>>> diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.h b/drivers/infiniband/sw/rxe/rxe_verbs.h
>>> index b286a14ec282..9f35e2c042d0 100644
>>> +++ b/drivers/infiniband/sw/rxe/rxe_verbs.h
>>> @@ -183,6 +183,7 @@ struct rxe_resp_info {
>>>
>>> /* RDMA read / atomic only */
>>> u64 va;
>>> + u64 offset;
>>> struct rxe_mr *mr;
>>> u32 resid;
>>> u32 rkey;
>>> @@ -470,6 +471,16 @@ static inline u32 mr_rkey(struct rxe_mr *mr)
>>> return mr->ibmr.rkey;
>>> }
>>>
>>> +static inline struct rxe_pd *mw_pd(struct rxe_mw *mw)
>>
>> inline
>> Can we remove inline keyword and let the compile to decide it?
>
> Not in a header
>
> Jason
>
I think this is the cleanest way to add these trivial functions. They don't really generate any code
just a different offset from the pointer.
Bob
