On 9/30/24 01:05, Paul Mackerras wrote: > Basically the patch looks good to me. I do need a Signed-off-by line > from you, or at least your permission to add one like the one below > for you. Let me know if you want me to add that for you and edit the > description, or if you would prefer to resubmit it. In the former > case I would edit the description to look like this: > > ------------------------------------------------------ > Bring Solaris port back up to date > > - Updated READMEs > - Disabled MPPE support for Solaris > - Fixed compilation error in ccp.c with MPPE disabled > - Use OS-provided drivers and associated include files > - Tested on OpenIndiana Hipster (Illumos) > > Signed-off-by: James Carlson <carlsonj@xxxxxxxxxxxxxxx> > ------------------------------------------------------ That looks fine to me. -- James Carlson 42.703N 71.076W FN42lq08 <carlsonj@xxxxxxxxxxxxxxx>