On Sat, Sep 21, 2024 at 05:04:49PM -0400, James Carlson wrote: > The attached patch for review brings the Solaris support back up to > date. Here is a summary of the changes it contains: > > - Updated readmes > - Disabled MPPE support for Solaris > - Fixed compilation error in ccp.c with MPPE disabled > - Use OS-provided drivers and associated include files > - Tested on OpenIndiana Hipster (Illumos) > > -- > James Carlson 42.703N 71.076W FN42lq08 <carlsonj@xxxxxxxxxxxxxxx> Thanks James, and I apologize for my slow response. Basically the patch looks good to me. I do need a Signed-off-by line from you, or at least your permission to add one like the one below for you. Let me know if you want me to add that for you and edit the description, or if you would prefer to resubmit it. In the former case I would edit the description to look like this: ------------------------------------------------------ Bring Solaris port back up to date - Updated READMEs - Disabled MPPE support for Solaris - Fixed compilation error in ccp.c with MPPE disabled - Use OS-provided drivers and associated include files - Tested on OpenIndiana Hipster (Illumos) Signed-off-by: James Carlson <carlsonj@xxxxxxxxxxxxxxx> ------------------------------------------------------ Thanks, Paul.