Richard Hartmann schrieb: > Hi Walter, > > >> ppp->rrsched never gets resetted, i assume that is somewhere else ? > > *cough* no *cough* > > >> can you move the whole block into a separate function ? >> then it will be easy to remove the ifdef stuff from the core function. > > Did you look at the most current version? It can be found within this > thread or here [1]. > > > Richard > > [1] http://lkml.org/lkml/2010/3/31/87 > Hi Richard, thats looks different. :) here my questions: from ppp_mp_roundrobin() if (ppp->rrsched % ppp->n_channels == i) since both do not change in that while() loop you can calculate in advance perhaps ppp->rrsched %= ppp->n_channels before the while ? (that would reduce my bad feels about variables that only increments also :) btw: you are doing after loop() if(pch->chan == NULL) continue; that means the else in the if below if (pch->chan) should never be reached. Or is it likely that some channel will be dropped (?) ? so the code says: go to channel (ppp->rrsched % ppp->n_channels) send packet pch->chan->ops->start_xmit(pch->chan, skb) btw: this is intentional ? looks strange if(ppp_ml_noexplode) { + } + else { just my 2 cents, re, wh -- To unsubscribe from this list: send the line "unsubscribe linux-ppp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
