* Konstantin Baydarov <kbaidarov@xxxxxxxxxxxxx> [120627 11:09]: > + > +/* TODO: Add helpers for 16bit and byte access */ > +#ifdef CONFIG_MFD_OMAP_CONTROL > +u32 omap_control_status_read(u16 offset); > +#else > +static inline u32 omap_control_status_read(u16 offset) > +{ > + return 0; > +} > +#endif This should be an exported function instead. And it should not need the offset as a parameter as the SCM core should know where to find it's control_status register. Regards, Tony