Re: [RFC/PATCH 8/9] OMAP: PM CONSTRAINTS: implement the devices wake-up latency constraints

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 27, 2011 at 8:33 PM, Todd Poynor <toddpoynor@xxxxxxxxxx> wrote:
> On Fri, Jun 24, 2011 at 04:38:05PM +0200, jean.pihet@xxxxxxxxxxxxxx wrote:
> ...
>> +     /* Find the associated omap_device for dev */
>> +     od = container_of(pdev, struct omap_device, pdev);
>> +     if (!od || (od->hwmods_cnt != 1)) {
>> +             pr_err("%s: Error: No unique hwmod for device %s\n",
>> +                    __func__, dev_name(pm_qos_req->dev));
>> +             return -EINVAL;
>
> Check for !od can be dropped... if there's a check for !pdev needed
> can add that, but container_of() won't return NULL for a valid
> contained field.
Ok fixed in the v2 version.

Thanks!
Jean


>
>
> Todd
>
_______________________________________________
linux-pm mailing list
linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/linux-pm



[Index of Archives]     [Linux ACPI]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [CPU Freq]     [Kernel Newbies]     [Fedora Kernel]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux