On Fri, Jun 24, 2011 at 04:38:05PM +0200, jean.pihet@xxxxxxxxxxxxxx wrote: ... > + /* Find the associated omap_device for dev */ > + od = container_of(pdev, struct omap_device, pdev); > + if (!od || (od->hwmods_cnt != 1)) { > + pr_err("%s: Error: No unique hwmod for device %s\n", > + __func__, dev_name(pm_qos_req->dev)); > + return -EINVAL; Check for !od can be dropped... if there's a check for !pdev needed can add that, but container_of() won't return NULL for a valid contained field. Todd _______________________________________________ linux-pm mailing list linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/linux-pm