Re: [RESEND PATCH] PM: add a config that give warnning if driver take too long on suspend/resume.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Hi Pavel,
> 
> 2011/4/13 Pavel Machek <pavel@xxxxxx>:
> > Hi!
> >
> >> > If you want to figure out which device suspend too slow, this patch
> >> > will do better.
> >>
> >> It's okay with me.  Presenting the information in an easy-to-read form
> >> is fine.  I just wanted to point out that the information is already
> >> available.
> >>
> >> BTW, there are several spelling errors in the Kconfig help text in your
> >> patch.  You should fix them before submitting the patch again.
> >
> > Well well. I'd avoid placing this in kernel. It seems that parsing
> > dmesg to get the "better" debugging information out is pretty much
> > trivial.
> 
> I'm admit it's not a big feather, but it's belong to PM_DEBUG, it's a
> debug feather.
> It's very useful in embedded Linux development. Also, when someone
> debugging suspend/resume in these system, they always have to
> implement a version like this. So I think add this debug feather to
> kernel can do some help.
> 
> I'm ok with drop this patch, I just want to clarify the aim of patch.

Good.

Adding helpful dmesg-parsing script to linux/scripts/ would not be a
bad idea, through.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
_______________________________________________
linux-pm mailing list
linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/linux-pm



[Index of Archives]     [Linux ACPI]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [CPU Freq]     [Kernel Newbies]     [Fedora Kernel]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux