Hi! > > > @@ -85,6 +86,12 @@ static int intel_idle(struct cpuidle_dev > > > static struct cpuidle_state *cpuidle_state_table; > > > > > > /* > > > + * Hardware C-state auto-demotion may not always be optimal. > > > + * Indicate which enable bits to clear here. > > > + */ > > > +static unsigned long long auto_demotion_disable_flags; > > > > Why long long here, but long above? > > long long here because MSR accesses are 64-bits, even on > 32-bit builds. > > UL above because it matches the style of the neighboring code. > The "UL" is purely cosmetic, of course. Same code is generated > if it were "ULL" or left off entirely; as the LHS is 64-bit. Normally, if register is always 64bit, it should be u64. And consistency should not be a reason to add misleading postfixes... Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html _______________________________________________ linux-pm mailing list linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/linux-pm
