On 04/30/2010 07:39 AM, Arve Hjønnevåg wrote: > On Thu, Apr 29, 2010 at 10:16 PM, Tejun Heo <tj@xxxxxxxxxx> wrote: >> Hello, >> >> On 04/29/2010 09:45 PM, Oleg Nesterov wrote: >>> -static struct workqueue_struct *keventd_wq __read_mostly; >>> +struct workqueue_struct *keventd_wq __read_mostly; >>> +EXPORT_SYMBOL(keventd_wq); >> >> Umm... does it have to be EXPORTed? Suspend block API can't be built >> as a module, right? > > The suspend block api cannot be built as a module, but if > schedule_suspend_blocking_work will just call > queue_suspend_blocking_work(keventd_wq, work) it may as well be an > inline function which would require the export. I think it would be better to keep the thing inside the kernel, at least for now. It's not like we need to save cpu cycles spent on a function call here (in block suspend API and in workqueue general). Thanks. -- tejun _______________________________________________ linux-pm mailing list linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/linux-pm
