On Mon, Sep 28, 2009 at 2:16 AM, Rafael J. Wysocki <rjw@xxxxxxx> wrote: > On Sunday 27 September 2009, Alan Stern wrote: >> On Sun, 27 Sep 2009, Rafael J. Wysocki wrote: >> >> > Tested, works. >> > >> > Greg, could you please consider taking the patch below? It fixes a recent >> > hibernation regression for me, so if not this one, another fix is necessary. >> >> This patch has a mistake. >> >> > Index: linux-2.6/drivers/usb/serial/usb-serial.c >> > =================================================================== >> > --- linux-2.6.orig/drivers/usb/serial/usb-serial.c >> > +++ linux-2.6/drivers/usb/serial/usb-serial.c >> > @@ -1210,7 +1210,7 @@ static const struct tty_operations seria >> > .chars_in_buffer = serial_chars_in_buffer, >> > .tiocmget = serial_tiocmget, >> > .tiocmset = serial_tiocmset, >> > - .shutdown = serial_release, >> > + .cleanup = serial_release, >> > .install = serial_install, >> > .proc_fops = &serial_proc_fops, >> > }; >> >> It isn't enough to change the method pointer. The code in >> serial_release() has to be changed too; it must not call tty_shutdown() >> any more. > > Would it be sufficient to remove the tty_shutdown() call from > serial_release()? I think so, because standard shutdown will be called in queue_release_one_tty. Alan, could you confirm about this? Thus I'd like to update the patch. > > Rafael > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- Regards dave _______________________________________________ linux-pm mailing list linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/linux-pm
