On Sunday 27 September 2009, Alan Stern wrote: > On Sun, 27 Sep 2009, Rafael J. Wysocki wrote: > > > Tested, works. > > > > Greg, could you please consider taking the patch below? It fixes a recent > > hibernation regression for me, so if not this one, another fix is necessary. > > This patch has a mistake. > > > Index: linux-2.6/drivers/usb/serial/usb-serial.c > > =================================================================== > > --- linux-2.6.orig/drivers/usb/serial/usb-serial.c > > +++ linux-2.6/drivers/usb/serial/usb-serial.c > > @@ -1210,7 +1210,7 @@ static const struct tty_operations seria > > .chars_in_buffer = serial_chars_in_buffer, > > .tiocmget = serial_tiocmget, > > .tiocmset = serial_tiocmset, > > - .shutdown = serial_release, > > + .cleanup = serial_release, > > .install = serial_install, > > .proc_fops = &serial_proc_fops, > > }; > > It isn't enough to change the method pointer. The code in > serial_release() has to be changed too; it must not call tty_shutdown() > any more. Would it be sufficient to remove the tty_shutdown() call from serial_release()? Rafael _______________________________________________ linux-pm mailing list linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/linux-pm
