Hi, Matthew, On Fri, 2008-01-18 at 09:42 +0800, Matthew Garrett wrote: > On Fri, Jan 18, 2008 at 09:31:40AM +0800, Zhang Rui wrote: > > > Just like I don't think lcd should be used for ACPI thermal > management > > before I saw it is listed in _TZD and intel_menlow requires to > throttle > > it when overheating, why not let the individual drivers implement > the > > callbacks if there is clearly a request to do this. > > And we can add this to the generic acpi_device struct then if this > is a > > common feature for all ACPI devices. > > It'll probably never be common for all ACPI devices, I agree. > but it's already > required for three types. I think that's a strong argument for making > it generic. I don't think it's worth doing this as it's only the common feature for three ACPI devices. > > Well, you're right. > > But in order to throttle the lcd, this is reasonable, right? > > Moving the common code into its own routine and then calling that from > each of the others would probably work. Yes. I can send an on top patch if the patch "Rationalise ACPI backlight implementation" is applied. Thanks, Rui _______________________________________________ linux-pm mailing list linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/linux-pm
