Hi! > > > --- linux-2.6.22-rc6-mm1.orig/kernel/power/process.c > > > +++ linux-2.6.22-rc6-mm1/kernel/power/process.c > > > @@ -237,20 +237,23 @@ static int try_to_freeze_tasks(int freez > > > */ > > > int freeze_processes(void) > > > { > > > - int error; > > > + int error = 0; > > > > You set error unconditionally few lines below. > > Ah, thanks. There were a couple of versions of this patch and I forgot to > remove this. > > > > - printk("Stopping tasks ... "); > > > + printk("Freezing user space processes ... "); > > > error = try_to_freeze_tasks(FREEZER_USER_SPACE); > > > if (error) > > > - return error; > > > + goto Exit; > > > + printk("done.\n"); > > > > > > + printk("Freezing remaining freezable tasks ... "); > > > > can we ust do printk(" rest ... "); ? Saves one line... and suspend > > process is too verbose anyway. > > In fact, this is related to the next patch, in which try_to_freeze_tasks() is > reworked and without this it won't be clear which phase of the freezing has > failed (in case of failure, that is). Ok, ACK , then. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html _______________________________________________ linux-pm mailing list linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/linux-pm