On Thursday, 21 June 2007 15:28, Pavel Machek wrote: > Hi! > > > The SNAPSHOT_S2RAM ioctl code is outdated and it should not duplicate the > > suspend code in kernel/power/main.c. Fix that. > > > > Signed-off-by: Rafael J. Wysocki <rjw@xxxxxxx> > > Mostly works ok, but > > > +/** > > + * suspend_suspend - suspend devices and enter the desired system sleep > > + * state. > > + * @state: state to enter > > + */ > > +int suspend_suspend(suspend_state_t state) > > This is really horrible name. Yes, I just couldn't invent anything else. > Maybe this should be suspend_enter, and suspend_enter should become > __suspend_enter, or something? Well, suspend_enter() is called from a couple of places and I wouldn't like to change that. I would like to call it pm_suspend(), but that one is already used. I have two candidates: __suspend() and suspend_devices_and_enter(). Greetings, Rafael -- "Premature optimization is the root of all evil." - Donald Knuth _______________________________________________ linux-pm mailing list linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/linux-pm
