Re: [RFC][PATCH] PM: Remove code duplication between main.c and user.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi!

> The SNAPSHOT_S2RAM ioctl code is outdated and it should not duplicate the
> suspend code in kernel/power/main.c.  Fix that.
> 
> Signed-off-by: Rafael J. Wysocki <rjw@xxxxxxx>

Mostly works ok, but

> +/**
> + *	suspend_suspend - suspend devices and enter the desired system sleep
> + *			  state.
> + *	@state:		  state to enter
> + */
> +int suspend_suspend(suspend_state_t state)

This is really horrible name. Maybe this should be suspend_enter, and
suspend_enter should become __suspend_enter, or something?
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
_______________________________________________
linux-pm mailing list
linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/linux-pm

[Index of Archives]     [Linux ACPI]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [CPU Freq]     [Kernel Newbies]     [Fedora Kernel]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux