On Sunday, 10 June 2007 22:37, Alan Stern wrote:
> On Sun, 10 Jun 2007, Rafael J. Wysocki wrote:
>
> > On Sunday, 10 June 2007 16:55, Alan Stern wrote:
> > > On Sun, 10 Jun 2007, Rafael J. Wysocki wrote:
> > >
> > > > From: Rafael J. Wysocki <rjw@xxxxxxx>
> > > >
> > > > Reduce code duplication in drivers/base/suspend.c by introducing an inline
> > > > function for printing diagnostic messages.
> > >
> > > Could you save object-code space by making the function non-inline?
> > > It looks complicated enough.
> >
> > I thought I would do that, but then I thought I'd want it to be compiled out if
> > dev_dbg() were a noop (like when the debugging is off).
>
> You can always do something like this:
>
> #ifdef DEBUG
>
> static void print_msg(...)
> {
> ...
> }
>
> #else
>
> static inline void print_msg(...)
> { }
> #endif
Well, IMHO, that doesn't look very nice. ;-)
Greetings,
Rafael
--
"Premature optimization is the root of all evil." - Donald Knuth
_______________________________________________
linux-pm mailing list
linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/linux-pm
