Re: [RFC][PATCH 1/2] PM: Reduce code duplication in the core suspend code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 10 Jun 2007, Rafael J. Wysocki wrote:

> On Sunday, 10 June 2007 16:55, Alan Stern wrote:
> > On Sun, 10 Jun 2007, Rafael J. Wysocki wrote:
> > 
> > > From: Rafael J. Wysocki <rjw@xxxxxxx>
> > > 
> > > Reduce code duplication in drivers/base/suspend.c by introducing an inline
> > > function for printing diagnostic messages.
> > 
> > Could you save object-code space by making the function non-inline?  
> > It looks complicated enough.
> 
> I thought I would do that, but then I thought I'd want it to be compiled out if
> dev_dbg() were a noop (like when the debugging is off).

You can always do something like this:

#ifdef DEBUG

static void print_msg(...)
{
...
}

#else

static inline void print_msg(...)
{ }
#endif

Alan Stern

_______________________________________________
linux-pm mailing list
linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/linux-pm

[Index of Archives]     [Linux ACPI]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [CPU Freq]     [Kernel Newbies]     [Fedora Kernel]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux