On Wed, 9 May 2007, Pavel Machek wrote: > Hi! > > > We give the user a chance to decide how this tradeoff should go when > > entering hibernation. Why not also give the user a chance to decide the > > tradeoff during normal shutdown? > > > > Yes, it violates the spec in the sense that we would be entering S4 > > without saving a memory image. > > I think you already replied to yourself :-). Yes -- but going to S5 during hibernation (which is what "echo shutdown >/sys/power/disk" does, right?) also violates the spec. So I don't feel too guilty about this. > There are more reasons, like we getting useless code paths to > debug. So far you demonstrated that S4-on-shutdown is probably > possible, and while violating specs, it should probably work. > > What do you expect now? Me jumping with joy and implementing > S4-on-shutdown because it should be possible? Actually all I wanted was someone to look over my reasoning and check that it was correct. You and Raphael have now done so, thank you. And when I first began contributing to this thread, the main purpose was to point out that hibernation_ops (or anything else related to the shutdown method) should not be involved in the steps responsible for creating and storing the snapshot image. > Now... if you feel very strongly about S4-on-shutdown, you may try to > create a patch. If it is not-too-ugly, and if it is really good for > something, we may merge it. At some time I might just do that... Alan Stern _______________________________________________ linux-pm mailing list linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/linux-pm
