Re: [RFC][PATCH] swsusp: Reduce code duplication between user.c and disk.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Monday, 7 May 2007 14:26, Pavel Machek wrote:
> On Mon 2007-05-07 13:43:11, Johannes Berg wrote:
> > Hi,
> > 
> > > However, this modifies the user-observable behavior in such a way that
> > > if the user sets 'shutdown mode = platform' in the s2disk's configuration file,
> > > the kernel will use the hibernation mode resulting from the sysfs interface
> > > settings.  That is, if there is 'shutdown mode = platform' in the s2disk's
> > > configuration file, but the hibernation mode is set to 'reboot' in the sysfs
> > > interface, the system will be rebooted instead of going for the 'ACPI S0->S4
> > > transition'.
> > 
> > This I don't understand. Without looking at the code, it seems that
> > you're invoking some common code that checks the sysfs file. Couldn't
> > those functions take an argument instead?
> 
> I'll second this. Can we pass down an argument, meaning userland
> interface does not change?

Yes, we can.  I'll have an updated patch in a couple of days.

Greetings,
Rafael
_______________________________________________
linux-pm mailing list
linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/linux-pm

[Index of Archives]     [Linux ACPI]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [CPU Freq]     [Kernel Newbies]     [Fedora Kernel]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux