Re: [RFC/PATCH 2/2] kernel: don't update load average during snapshot/shutdown

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi!

> > NAK. This slows down regular operation, at it is 30 lines for what
> > should have been one (or five).
> 
> Count them. It is one line (an if statement) plus seven lines of
> comment.

You count them. Hint... you'll need to read original patch.

> > Just place avenrun[0] = avenrun[1] = avenrun[2] = 0 at strategic place
> > if you feel strongly about this. Additional points for using Rafael's
> > "suspend done" notifier so that you don't have to modify suspend core.
> 
> =0 might not be right. If you did have a high load average prior to
> suspending, not delivering email would be the right thing to do.

Ok, so =0 is not right, but it is better than adding 30lines of junk
to the kernel.

NAK on this patch. Original behaviour is acceptable.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
_______________________________________________
linux-pm mailing list
linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/linux-pm

[Index of Archives]     [Linux ACPI]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [CPU Freq]     [Kernel Newbies]     [Fedora Kernel]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux