On Saturday 21 April 2007, Pavel Machek wrote:
> Hi!
>
> > > int suspend_enter(suspend_state_t state)
> > > {
> > > int error = 0;
> > > - unsigned long flags;
> > >
> > > - local_irq_save(flags);
> > > + arch_s2ram_disable_irqs();
> >
> > Sorry for not highlighting this before, but these are badly misnamed.
> > They apply for every system suspend state except PM_SUSPEND_DISK ...
> > NOT just suspend-to-ram, as specified by the function name.
>
> Every suspend state means "standby" and "s2ram" in this context. I
> think this name is better than alternatives.
Every suspend state is **NOT** s2ram though.
This is a very straightforward point. A function that's
called on non-S2RAM paths shouldn't be named as if it's
only for S2RAM.
Ergo, those two functions are misnamed. End of story.
- Dave
_______________________________________________
linux-pm mailing list
linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/linux-pm
