On Saturday 21 April 2007, Johannes Berg wrote: > int suspend_enter(suspend_state_t state) > { > int error = 0; > - unsigned long flags; > > - local_irq_save(flags); > + arch_s2ram_disable_irqs(); Sorry for not highlighting this before, but these are badly misnamed. They apply for every system suspend state except PM_SUSPEND_DISK ... NOT just suspend-to-ram, as specified by the function name. > + BUG_ON(!irqs_disabled()); > > if ((error = device_power_down(PMSG_SUSPEND))) { > printk(KERN_ERR "Some devices failed to power down\n"); > @@ -143,7 +164,8 @@ int suspend_enter(suspend_state_t state) > error = pm_ops->enter(state); > device_power_up(); > Done: > - local_irq_restore(flags); > + arch_s2ram_enable_irqs(); Same here. > + BUG_ON(irqs_disabled()); > return error; > } > > _______________________________________________ linux-pm mailing list linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/linux-pm