On Птн, 2007-04-06 at 19:43 +0400, Dmitry Krivoschokov wrote:[skipped]> The struct resource was initially intended for IO resources only,> (which looks wrong to me, at least its naming, it could be called> as io_resources). But voltage is not an IO resource, so struct resource> is not appropriate place for thatYou object on naming of the structure (have you ever tried to do outputon interrupt line :) )? The struct resource layout is not well suitable to keep informationabout clocks/voltage and ever gpio lines, but all of these things areresources. Resources of device. Well, resources that belongs toplatform_device. I don't like idea to keep two separate lists of resources - one for I/Oports/memory windows/IRQ lines and the another one to keep pm resources.Why should they be separated ? > >This might sound odd, but after all, why not look at power [voltage] as> >a resource just loke memory, IO ports, GPIO or IRQ lines?> >> I'd consider voltage and clocks as a power resources, every computer> (say CMOS) system (or device) consumes (requires for) voltage and clocks,> so it looks natural that device driver will check what resources> are needed for device on this particular platform.> > >> >This keeps the drivers clean from having to know any device specifics.> >> >> Yep.> > >It also keeps the actual device driver of any peripheral independent of> >the PMU driver, since the latter would sit behind the 'struct resource'> >abstraction. > >A device driver would then just call something like> >requrest_power(struct resource *) whic hides all the magic of> >calling back into the individual PMU driver.> >> It assumes some infrastructure to deal with power resources, like> we have for interrupts now.> > Actually, all Linux PM-related problems are discussed on> linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx list, here it's offtopic.> Continue the discassion on linux-pm, if you will.I added linux-pm to Cc, so let's continue there.> > > Thanks,> Dmitry> > > -------------------------------------------------------------------> List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel> FAQ: http://www.arm.linux.org.uk/mailinglists/faq.php> Etiquette: http://www.arm.linux.org.uk/mailinglists/etiquette.php _______________________________________________linux-pm mailing listlinux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx://lists.linux-foundation.org/mailman/listinfo/linux-pm
