On Thu, Mar 22, 2007 at 03:33:13PM +0100, Pavel Machek wrote: > On Thu 2007-03-22 23:24:37, Paul Mundt wrote: > > On Thu, Mar 22, 2007 at 02:31:17PM +0100, Pavel Machek wrote: > > > Hohum, perhaps it can suspend to SD card? Or perhaps it can suspend > > > over network? > > > > > > Suspend code will properly fail if there's not enough swap space. > > > > > > ...plus you are allowed to return -EINVAL from arch_prepare_suspend() > > > or how is it called. > > > > So then how exactly is this helping anything? It's pointless to have the > > sysfs file visible for platforms that are never going to support suspend > > to disk, and -EINVAL'ing out in another path is simply moving the > > problem. > > Platforms that are never going to support s2disk > > a) should be fixed > > b) do not have CONFIG_SOFTWARE_SUSPEND. Ah, that's the part I was missing. Ok, As long as the memory-only thing is explicit, then I don't see any problem with these. Acked-by: Paul Mundt <lethal@xxxxxxxxxxxx> _______________________________________________ linux-pm mailing list linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/linux-pm
