Re: + rework-pm_ops-pm_disk_mode-kill-misuse.patch added to -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2007-03-22 at 11:03 +0100, Pavel Machek wrote:

> > So they shouldn't offer it in Kconfig?

I agree with that.

> Anyway, this patch is good, as it allows interested ARM machines to
> really disable suspend-to-disk. What they were doing previously was
> not effective.

I thought you just said you understood pm_ops now :->

No, once SOFTWARE_SUSPEND is configured there's *no way* to disable it
after the fact via pm_ops. Read valid_state() in kernel/power/main.c.

But that's a design decision, once the kernel config allows suspend to
disk runtime pm_ops have no say in it. And what they previously did by
nack'ing suspend to disk for platform mode is broken and just papers
over the problem in the default case, once the user puts shutdown
> /sys/power/disk the problem shows up again (if there is any).

johannes

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
linux-pm mailing list
linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/linux-pm

[Index of Archives]     [Linux ACPI]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [CPU Freq]     [Kernel Newbies]     [Fedora Kernel]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux