Hi, > > I also used to think this was for implementing suspend-to-both, is that > > wrong? In any case, I can't live with it being platform by default > > No, it is to get ACPI working after resume. Yeah, I noticed later on. Sorry for the misunderstanding. > > Maybe we just need a pm_disk_modes bitmap and a default_pm_disk_mode > > member in struct pm_ops instead? What's firmware vs. platform anyway? > > bitmap would be nice. Firmware used to mean "let the bios do the whole > suspend", platform means "linux does the suspend, but we tell bios we > are doing it", shutdown means "linux does the suspend, does not tell > anyone". Well, actually, "let the bios do the whole suspend" should be implemented by a new PM_SUSPEND_FIRMWAREDISK mode that can be used instead of "disk" and is invoked through pm_ops directly w/o hitting the disk.c code. That would be the right way to invoke such a mode, however, currently, no platforms even have such a mode as far as I can tell. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
_______________________________________________ linux-pm mailing list linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/linux-pm