Hi, This suspend to disk modes stuff really sucks. The last time I looked must have been a long time ago because then shutdown was default. Now I find that in November 06 you changed it to be platform by default. The problem with this is that not all platforms support the "platform" mode. I have a pm_ops struct for PMU-based Apple powerpc machines that doesn't set pm_disk_mode in order not to allow the platform mode because that currently fails. I also used to think this was for implementing suspend-to-both, is that wrong? In any case, I can't live with it being platform by default because that goes into really weird behaviour, or I need to special-case the ->enter callback for suspend to disk to just shut down again. Could you please post a patch to change the documentation in pm.h to indicate what the pm_disk_mode is intended for? It also doesn't help my willingness to work on and with the generic suspend to disk stuff that the patch I'm referring to was posted as if it was ACPI specific... Maybe we just need a pm_disk_modes bitmap and a default_pm_disk_mode member in struct pm_ops instead? What's firmware vs. platform anyway? Thanks, johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
_______________________________________________ linux-pm mailing list linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/linux-pm
