Hi! > > /* -------------------------------------------------------------------------- > + FS Interface (/sys) > + -------------------------------------------------------------------------- */ > +extern struct subsystem acpi_subsys; > + > +static ssize_t info_show(struct subsystem *subsys, char *buf) > +{ > + return sprintf(buf, "version: %x\n", ACPI_CA_VERSION); > +} One value per file... so it should omit "version: " string at the very least. Plus I do not think we should have this file at all. ACPI is pretty much in sync with kernel these days, and we do not have /sys/scsi/scsi_core version nor /sys/vm/vm_internals_version etc. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html