On Saturday 06 January 2007 3:35 am, Zhang Rui wrote: > +static struct subsys_attribute info_attr = { > + .attr = { > + .name = __stringify(info), > + .mode = 0444, > + }, > + .show = info_show, > + .store = NULL, > +}; Please don't expand __ATTR_RO(info) by hand; notice what your manual version omitted, for one thing ...