Hi!
> > > Some nitpicking about the patch follows..
> > >
> > > On Sat, Sep 30, 2006 at 02:24:35AM +0400, Eugeny S. Mints wrote:
> > > > +static long
> > > > +get_vtg(const char *vdomain)
> > > > +{
> > > > + long ret = 0;
> > >
> > > Unnecessary initialisation.
> >
> > No, sorry.
>
> In get_vtg(), if VOLTAGE_FRAMEWORK is defined then
>
> ret = vtg_get_voltage(v);
>
> is the first user. If VOLTAGE_FRAMEWORK is not defined, the first user is:
>
> ret = vtg_get_voltage(&vhandle);
>
> Then "return ret;" follows. I cannot see a path where
> pre-initialisation of ret does anything useful. If someone removed the
> #else part, the compiler would bark.
Ahha, sorry, I did not look at this kind of context.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
